Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

&& Kate (Not my proudest work) #45

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

&& Kate (Not my proudest work) #45

wants to merge 17 commits into from

Conversation

Oh-KPond
Copy link

@Oh-KPond Oh-KPond commented Mar 22, 2018 •
edited
Loading

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Didn't run it through the validator.
Why is it important to consider and use semantic HTML? Using semantic HTML helps screen readers and in turn helps with accessibility on the site.
How did you decide to structure your CSS? I have a reset css stylesheet to clear all browser loaded styles, a global css for any content that's repeated throughout the site, and a style sheet for each individual page.
What was the most challenging piece of this assignment? Trying to think the assignment while other things are going on in my life... mmm I guess I'm still getting a grip on the best ways to use grid and flexbox, and there are a lot of other things I like to do with the site, including a sticky nav and some images, and the portfolio page... I have lots of ideas...
Describe one area that you gained more clarity on when completing this assignment That it is really tough to do design work, and it's especially hard when you can't concentrate.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? Nope.
Overall

@CheezItMan
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage Good commit messages and good number of commits
Answered comprehension questions Check, try using the validator in the future. It's helpful
Page fully loads Check
No broken links (regular or images) Some broken links, see my notes
Includes at least 4 pages and styling Only 3 pages
HTML
Uses the high-level tags for organization: header, footer, main No high-level grouping, I would suggest doing that in the future as it can make the page easier to organize.
Appropriately using semantic tags: section, article, etc. Check!
All images include alternate text Check!
CSS
Using class and ID names in style declarations Only using classes, which is perfectly fine
Style declarations are DRY Very Dry, nice!
Overall Well done, You're obviously not finished, but it already looks pretty good. Just a note, it's not responsive, but that wasn't a requirement, just a note. You are on the right track here!

CheezItMan
CheezItMan reviewed Mar 31, 2018
View reviewed changes
content/about.html
<nav>
<ul>
<li class="logo"><a href="../index.html"><img src="../assets/PondsEdgeSmall.svg" alt="The Pond's Edge Logo"></a></li>
<li><a class="nav-work" href="#">Work</a></li>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The anchor tags need to be fixed here.

content/work.html
<nav>
<ul>
<li class="logo"><a href="../index.html"><img src="../assets/PondsEdgeSmall.svg" alt="The Pond's Edge Logo"></a></li>
<li><a class="nav-work" href="#">Work</a></li>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The links here need to be finished.

index.html

<nav>
<ul>
<li class="logo"><a href="#"><img src="assets/PondsEdgeColorSmall.svg" alt="The Pond's Edge Logo"></a></li>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More links to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oh-KPond @CheezItMan